Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh fetch with custome port #1470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jakob30061
Copy link

@jakob30061 jakob30061 commented Sep 7, 2023

This adds support for custom ssh ports. If github-server-url has a url with a different ssh port like (https://example.com:222) and fetching with ssh is selected, this commit adds the required ssh:// and the port to the origin url.

Tested with custom ssh port (https://example.com:222), no ssh port (https://example.com) where default port 22 is used and with default port 22 explicitly set (https://example.com:22).

closes #1315

@jakob30061 jakob30061 requested a review from a team as a code owner September 7, 2023 22:24
@jakob30061
Copy link
Author

jakob30061 commented Sep 28, 2023

Is this needed?

@jbgomond
Copy link

jbgomond commented Oct 1, 2023

Big yes for that one. I cannot use the step in my case without it :(

@jafnhaar
Copy link

jafnhaar commented Oct 5, 2023

Want that feature

@lucas-stauder
Copy link

Would be great to have!

@jakob30061 jakob30061 requested a review from a team as a code owner January 8, 2024 10:34
@jakob30061
Copy link
Author

Big yes for that one. I cannot use the step in my case without it :(

You can use this PR until (if ever) this is merged

-uses: actions/checkout@v4
+uses: https://github.com/jakob30061/checkout@add-ssh-fetch-with-custome-port

@freeware-superman
Copy link

Hi,
Thank you for your work.
I guess that it is just my own incompetence and lack of patience, but I wasn't able to set it up myself.
Thus, I used a work around that I found myself and described at an open issue: #1315 (comment).

This workaround might work with any upstream tags as it modifies the ssh config file, but I've only tested v3.

I hope this can help someone until there is a proper fix merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for custom SSH port
5 participants