Fix: Don't remove auth if submodules are off #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gold1959
approved these changes
Jul 10, 2022
Gold1959
approved these changes
Jul 10, 2022
Ellajoke
approved these changes
Jul 15, 2022
Ellajoke
approved these changes
Jul 15, 2022
cg1211973
approved these changes
Jul 22, 2022
markjm
approved these changes
Oct 6, 2022
|
@markjm @cg1211973 @Ellajoke @Gold1959 can you folks merge this change? |
|
I am a mere onlooker with the same problem hoping for a resolution :( dont have merge powers unfortunately |
|
Hitting this too, please merge. |
|
Is this same as #1051 ? |
|
Any progress on this? It's a showstopper. |
tomasbw
approved these changes
Feb 8, 2023
|
Please merge, this is really a showstopper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the action tries to remove auth even the submodules are disabled.
Fixes #610.