Allow slashes in purl package names #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrysav
approved these changes
May 2, 2024
There was a problem hiding this comment.
I'm kind of uncomfortable with this as it actually might take a stance on the ambiguity eg. is the namespace gopkg.in/DataDog or just gopkg.in?
However this appears to be an unresolved point of discussion in the PURL community: package-url/purl-spec#63
So I think increasing permissiveness on our end is fine.
|
@mrysav that's a good callout, and we may have to revisit that later if the purl-spec folks ever work this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #764.
You are not supposed to have
/characters in a package name, but people intuitively want to put them in there anyway and it's still fully possible to parse them. Since the goal of our purl handling here is maximum permissiveness within reason, I made a little tweak to the parser so that we can handle this case.