Fix e2e handling for PRs in forks #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
changed the title
fritx
added a commit
to fritx/jsonmerge
that referenced
this pull request
Jan 22, 2024
https://github.com/marketplace/actions/git-auto-commit#use-in-forks-from-public-repositories stefanzweifel/git-auto-commit-action#211 https://github.com/orgs/community/discussions/26829#discussioncomment-3253580 winglang/wing#5115 pyiron/actions#44 UffizziCloud/preview-action#80 ASFHyP3/hyp3-isce2#179 tveastman/secateur#54 stm32-rs/stm32-rs#949 actions/gh-actions-cache#73
fritx
added a commit
to Jayin/jsonmerge
that referenced
this pull request
Jan 22, 2024
https://github.com/marketplace/actions/git-auto-commit#use-in-forks-from-public-repositories stefanzweifel/git-auto-commit-action#211 https://github.com/orgs/community/discussions/26829#discussioncomment-3253580 winglang/wing#5115 pyiron/actions#44 UffizziCloud/preview-action#80 ASFHyP3/hyp3-isce2#179 tveastman/secateur#54 stm32-rs/stm32-rs#949 actions/gh-actions-cache#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Doing work in/from forks should not result in ❌.
What approach did you choose and why?
#24 introduced e2e tests that require all repositories with actions enabled that either update their
mainbranch or receive PRs to theirmainbranch to have a valid and currentsecrets.REPO_WRITE_TOKEN-- this is frustrating for people who do work in or from forks. PRs from forks do not get access to secrets, and thus they will fail miserably, as in https://github.com/actions/gh-actions-cache/actions/runs/5301791880/jobs/9600582421I considered adding a fallback, but afaict there's nothing remotely special about what this code is doing, so I merely defined correct permissions which enables this workflow to work out of the box in forks
or for PRs to this repo from forks.I've also made the slack hook conditional on the presence of the slack secret, as I'm not planning to add that secret to my fork(s).
Anything you want to highlight for special attention from reviewers?
The current changes only able PRs to work in forks, they don't allow PRs to work across forks, to do that would require switching from
pull_requesttopull_request_targetwhich is perhaps scarier.