Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump dependencies #154

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump dependencies #154

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Aug 30, 2021

Hi @joshmgross, the problem is coming from the test that are validating the addition of Go to the Path.
So for the moment, this PR is going to upgrade the non-breaking upgrades.

Replaces #144

@mmorel-35 mmorel-35 marked this pull request as ready for review August 30, 2021 18:09
@mmorel-35 mmorel-35 requested a review from a team August 30, 2021 18:09
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@mmorel-35
Copy link
Author

mmorel-35 commented Sep 1, 2021

The check-dist job is in failure because of the issue fixed here actions/http-client#59 .
A new release of http-client is going to be needed.

Run npm run build

> setup-go@1.0.0 build /home/runner/work/setup-go/setup-go
> tsc && ncc build

Error: node_modules/@actions/http-client/interfaces.d.ts(29,16): error TS2304: Cannot find name 'URL'.

Adressing actions/http-client#22 would avoid this kind of problems in the future.

@mmorel-35
Copy link
Author

Hi @joshmgross, any updates on this?

@joshmgross
Copy link
Member

👋 Hey @mmorel-35, this will need a review from the team that maintains this action.

@mmorel-35 mmorel-35 closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants