Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for restore caching #297

Conversation

dmitry-shibanov
Copy link
Contributor

Description:
In scope of this pull request we add error handling to throw error only for ValidationError.

Related issue: #295

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Pompo17102
Copy link

Deposit through the bitcoin wallet for any help
bc1q5v34g2dym8c7x5mpfp7wdqp5hse38p99p4dggx

@dmitry-shibanov
Copy link
Contributor Author

Hello @brcrista. Could you please take a look at this pull request?

Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change, but how does it relate to #295?

@brcrista brcrista requested a review from a team March 28, 2022 15:16
@brcrista
Copy link
Contributor

@actions/actions-cache, do you have any feedback? For context, the setup- actions use the @actions/cache package to cache dependencies directly, which lets you omit actions/cache as a separate step.

@dmitry-shibanov
Copy link
Contributor Author

Hello @brcrista. Actually, as I checked the issue reproduces with node 16 only. On the previous action version it works as expected. I think it's related itself to the change of the default node version and buffer size. I could reproduce the same behaviour with action/cache when I removed this error handling logic and archive size was more than 2147483647.

@aparna-ravindra
Copy link
Contributor

might this be related to actions/toolkit#1030 ?

@dmitry-shibanov
Copy link
Contributor Author

Thank you @aparna-ravindra. It works. I've updated the pull request.

@dmitry-shibanov
Copy link
Contributor Author

I'm going to close the pull request because the issue was resolved in scope of this pull request #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants