New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle JDK 21 support #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for updating! Please note that this is Oracle JDK and not OpenJDK. |
You’re right @fniephaus ! I’ve been typing OpenJDK too much at work! I updated the title and description. |
What's the status of this PR? I'd really appreciate being able to use JDK 21 in actions. Thanks! |
Hi, @rjeberhard 👋 We'll take a look at the PR, but even without it, you already can install Oracle JDK 21 with setup-java. |
README.md
Outdated
@@ -88,7 +88,7 @@ steps: | |||
|
|||
#### Supported version syntax | |||
The `java-version` input supports an exact version or a version range using [SemVer](https://semver.org/) notation: | |||
- major versions: `8`, `11`, `16`, `17` | |||
- major versions: `8`, `11`, `16`, `17`, `21` | |||
- more specific versions: `17.0`, `11.0`, `11.0.4`, `8.0.232`, `8.0.282+8` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also add support for specific versions? ie : 21.0.1
or will this be included in a subsequent change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's only the documentation, but yes more generally the minor and patch versions will work
@asolntsev I'm sorry but I just contributed this small PR and I'm not a member of the project, I have no idea when they'll do a release |
Oracle JDK 21 should already be working fine. This PR just adds documentation and a test for it. Just specify java-version 21 or 21.0.1 or something like that and you should be good to go. Otherwise, please notify us here 🙂 |
@fniephaus Thank you for the response. I confirm, Java 21 is usable (see my working snippet below). The documentation should reflect the truth, right? - name: Set up JDK
uses: actions/setup-java@v4
with:
java-version: '21'
distribution: 'temurin' |
In the GitHub Actions workflow: - Update actions/checkout to the latest version - Update actions/setup-java to the latest version (Java 21 already works but is undocumented, the next version it will be thanks to actions/setup-java#538 😀)
Add test and documentation for Oracle JDK 21 support.
There will be more to do when the other distributions support it, but it's the first at the moment.
Check list: