Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP errors when the token is undefined #556

Merged
merged 2 commits into from Dec 1, 2023

Conversation

peter-murray
Copy link
Contributor

Description:
When the token is undefined (as the use of the action is not on dotcom), the http library is generating an error as the authorization header is set to undefined.

This change only populates the authorization header if there is a value present which makes this action work correctly for Microsoft variants of Java when not on dotcom.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@peter-murray peter-murray requested a review from a team as a code owner November 17, 2023 12:15
@IvanZosimov IvanZosimov added needs eyes feature request New feature or request to improve the current logic labels Nov 17, 2023
@IvanZosimov IvanZosimov self-assigned this Dec 1, 2023
@IvanZosimov IvanZosimov merged commit 16ef37f into actions:main Dec 1, 2023
259 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants