Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 16 deprecation #850

Closed
kinano opened this issue Sep 6, 2023 · 8 comments
Closed

Node 16 deprecation #850

kinano opened this issue Sep 6, 2023 · 8 comments
Assignees
@dmitry-shibanov
Labels
feature request New feature or request to improve the current logic needs eyes

Comments

@kinano
Copy link

kinano commented Sep 6, 2023

Node16 will be deprecated on 09/11/2023 (link).

Node 16 is used by the action at the moment according to the source code:

setup-node/action.yml

Lines 35 to 36 in 5e21ff4

runs:
using: 'node16'

Is there a plan to release a node version update soon?
@kinano kinano added feature request New feature or request to improve the current logic needs triage labels Sep 6, 2023
@dusan-trickovic
Copy link

Hello, @kinano! Thank you for creating an issue, we'll look into this :)

@MikeMcC399
Copy link

@dusan-trickovic

Based on the announcement GitHub Actions: Transitioning from Node 16 to Node 20 the current version of this JavaScript Action v3.8.1 will cause node16 deprecation notices to be generated starting on October 23, 2023.

So apart from the fact the Node.js 16 is already in end-of-life status, it will soon start to visibly affect GitHub Action workflows using actions/setup-node if no steps are taken to provide an updated release running on node20.

Please release a new version supporting node20 as requested by @kinano!

@dusan-trickovic
Copy link

Hello @MikeMcC399! Thank you very much for your input, we are looking into this :)

@dmitry-shibanov dmitry-shibanov mentioned this issue Oct 10, 2023
Merged
2 tasks
@MikeMcC399

This comment was marked as outdated.

Sign in to view
@MikeMcC399
Copy link

MikeMcC399 commented Oct 23, 2023 •
edited

timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Oct 28, 2023
@timvandermeij
Upgrade setup-node to version 4 in the GitHub Action workflows
fafbf1b 
This major version mainly involves not using Node.js 16 internally
anymore, which will be end of life on September 11th. This prevents the
workflows from using an unsupported version of Node.js as well as
deprecation warnings getting printed in the workflow logs.

For more information please refer to
https://github.com/actions/setup-node/releases/tag/v4.0.0 and
actions/setup-node#850.
@timvandermeij timvandermeij mentioned this issue Oct 28, 2023
Merged
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Oct 28, 2023
@timvandermeij
Upgrade setup-node to version 4 in the GitHub Actions workflows
6dff90a 
This major version mainly involves not using Node.js 16 internally
anymore, which will be end of life on September 11th. This prevents the
workflows from using an unsupported version of Node.js as well as
deprecation warnings getting printed in the workflow logs.

For more information please refer to
https://github.com/actions/setup-node/releases/tag/v4.0.0 and
actions/setup-node#850.
@edasmalchi edasmalchi mentioned this issue Nov 28, 2023
Closed
@dmitry-shibanov dmitry-shibanov self-assigned this Dec 25, 2023
@dmitry-shibanov
Copy link
Contributor

Hello everyone. The new version with support of node20 was released in v4.0.0. For now I'm going to close the issue.

@2wheeh 2wheeh mentioned this issue Jan 30, 2024
Closed
@MikeMcC399
Copy link

@rwader-swi

You need to change actions/setup-node@v3 to actions/setup-node@v4 in your workflow.

@rwader-swi
Copy link

@rwader-swi

You need to change actions/setup-node@v3 to actions/setup-node@v4 in your workflow.

yes I just did that. Thanks

@tisonkun tisonkun mentioned this issue Feb 18, 2024
Merged
3 tasks
@vshah11 vshah11 mentioned this issue Mar 8, 2024
Closed
planetsLightningArrester added a commit to planetsLightningArrester/leitor-de-notas-de-corretagem that referenced this issue Mar 10, 2024
@planetsLightningArrester
chore(ops): bump actions/setup-node to v4 (actions/setup-node#850)
dd19cf2
@alaingdl alaingdl mentioned this issue Mar 29, 2024
Merged
@armins armins mentioned this issue Apr 12, 2024
Open
@yqchilde yqchilde mentioned this issue Apr 26, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-shibanov dmitry-shibanov

Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kinano @dmitry-shibanov @MikeMcC399 @dusan-trickovic @rwader-swi