Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecoverage to use actions/checkout@v4 #1794

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

jkohnert
Copy link
Contributor

Fix Node-16 depcrations message for codecoverage.

@alaingdl
Copy link
Contributor

Could you please explain a little mode or give a like to document that, thank !
(is that link relevant ? actions/setup-node#850 )

@jkohnert
Copy link
Contributor Author

Pretty much, yes. The codecov job issues a warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3.5.2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Reading though this documentation leads to this page suggesting v4 (or, v4.2.0, if one wants to be more specific).

I'm not too familiar with github's actions, since we're using gitlab at work, and I use gitlab privately, too, but as far as I can tell,this should be the way to go.

I later saw, the probably outdated action is used at more places, maybe I should use this PR to update those usages, too. What do you think?

Best regards Jan

@slayoo
Copy link
Member

slayoo commented Mar 30, 2024

@alaingdl
Copy link
Contributor

Thanks you, I never noticed because I jump immediately to the red cross item !

@alaingdl alaingdl closed this Mar 31, 2024
@alaingdl alaingdl reopened this Mar 31, 2024
@alaingdl alaingdl merged commit 0089477 into gnudatalanguage:master Mar 31, 2024
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants