Replace dash to slash for asdf lts syntax #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doong-jo
force-pushed
the
support-lts-node-version-for-asdf
branch
from
2dd7314
to
ed77a6b
Compare
dsame
approved these changes
Jul 12, 2023
dusan-trickovic
approved these changes
Jul 12, 2023
|
Hello @doong-jo. Thank you for your pull request. Could you please sync with the main branch and add a new syntax to versions.yml matrix ? |
doong-jo
force-pushed
the
support-lts-node-version-for-asdf
branch
from
9370701
to
5ef044f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When using the Node.js LTS code names in asdf and setup-node, there is a difference in the format of the code name. For example, asdf requires the code name with dashes included, while setup-node requires the code name with slashes included. This needs to be corrected.
Related issue:
#373
Check list: