run update_resource inside a transaction to avoid autosaving relationships through assign_attributes when the record is invalid #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjulio
force-pushed
the
5430_fix_autosaving_relationships_on_invalid_resource
branch
from
c4bc6c4
to
50a9275
Compare
javierjulio
approved these changes
Mar 12, 2023
…ships through assign_attributes when the record is invalid
javierjulio
force-pushed
the
5430_fix_autosaving_relationships_on_invalid_resource
branch
from
50a9275
to
ab27f84
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7437 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 308 308
Lines 11306 11310 +4
=======================================
+ Hits 11247 11251 +4
Misses 59 59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@deivid-rodriguez @javierjulio is this planned to be merged at some point? it solves an important issue |
|
I also just encountered that issue, this fix is important and should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of #6202, to not let it be forgotten.
Fixes #5430
When submitting a form with invalid attributes, some associations are autosaved via assign_attributes before calling save_resource. As a consequence, when updating a resource, the user sees a validation error and is not aware that the changes to the associations got persisted.
This PR runs the code inside the update_resource method in an ActiveRecord::Transaction so that everything is rolled back when the model is not valid.