Remove deprecated #search method
#1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Tests against 6-0-stable don't pass in master branch also. |
|
Test failure against 6-0-stable is triggered by rails/rails#39268 . |
|
I've just found this failure but have no idea how to fix it yet. Also, this method should be Rails non-public API which can be changed without warnings. |
|
FYI #1171 addresses the CI failure. |
|
@y-yagi please rebase and rerun the CI |
y-yagi
force-pushed
the
remove_deprecated_search
branch
from
33d8fbe
to
7983167
Compare
|
@seanfcarroll Done! |
|
Thanks @y-yagi as this is removing deprecated functions, it should be on a major version bump, ie: 3.0.0 Will do it when that version is released. |
|
@y-yagi FYI we can probably do a major version bump soon, so thank you for being patient. |
|
@y-yagi Can you rebase this? I think we can proceed with Ransack 3.0.0 now and include this PR. |
`#search` is deprecated in v2.1.1 and it scheduled to remove the method in v2.3. activerecord-hackery#975 But the method still exists in v2.3.2. So let's remove the method. If we removed the method, users can remove the patch for `search` (`ActiveRecord::Base.class_eval('remove_method :search'`).
y-yagi
force-pushed
the
remove_deprecated_search
branch
from
7983167
to
edaf306
Compare
|
@deivid-rodriguez Done! |
deivid-rodriguez
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#searchis deprecated in v2.1.1 and it scheduled to remove the method in v2.3.#975
But the method still exists in v2.3.2. So let's remove the method.
If we removed the method, users can remove the patch for
search(ActiveRecord::Base.class_eval('remove_method :search').