Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add API diff to CI #3002

Merged
merged 2 commits into from Mar 15, 2023
Merged

add API diff to CI #3002

merged 2 commits into from Mar 15, 2023

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Mar 15, 2023 •
edited

PR Type

CI

PR Checklist

  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Some CI improvements, but mainly addding public API diff job.

@robjtede robjtede force-pushed the api-diff branch 11 times, most recently from 40fe222 to 8f9491c Compare March 15, 2023 04:22
@robjtede robjtede added the A-meta project organisation label Mar 15, 2023
@robjtede robjtede marked this pull request as ready for review March 15, 2023 04:30
@robjtede robjtede requested a review from JohnTitor March 15, 2023 05:11
JohnTitor
JohnTitor approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actix/actix-web/actions/runs/4423179234/jobs/7755654967 looks great 👍

@robjtede robjtede merged commit e68f87f into master Mar 15, 2023
@robjtede robjtede deleted the api-diff branch March 15, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
A-meta project organisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robjtede @JohnTitor