actix-test: re-export types from awc #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to pass these types around in functions, without having to add `awc` as a direct (dev-)dependency.
|
I'm not seeing the relationship between my PR and the CI failures; my changes don't seem to relate to TlsConnectorService at all... |
|
I think those test failures are related to rust 1.78, which just released and is now better at detecting unused code |
|
Well, I'm glad it's not my fault, because I had no idea how to fix it. 😀 I guess a merge/rebase/whatever once the underlying problem is sorted will green up CI to clear for merge. |
|
Working on a fix for the build failures: #3350 |
robjtede
approved these changes
May 18, 2024
|
Thanks, this is a fair enough improvement 👍🏻 |
jonatansalemes
pushed a commit
to jonatansalemes/actix-web
that referenced
this pull request
May 19, 2024
This allows us to pass these types around in functions, without having to add `awc` as a direct (dev-)dependency. Co-authored-by: Rob Ede <robjtede@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
... Other, I guess?
PR Checklist
Overview
At present, if you want to be able to pass (for example) the response from
srv.get()...to a function (so you can, say, parse out the response body and parse it as HTML), you've got to addawcas a dependency andusethe types from there.This change re-exports these
awctypes directly, to avoid the need for the extra dependency, as well as the risk of dependencies getting out of sync and laying waste to the landscape.