Expose actix::ContextFut::restart to public API
#567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
reviewed
Sep 12, 2023
|
@robjtede Can you please check the changes? |
|
@robjtede Any updates on this PR? |
|
Merged the last changes from |
|
@robjtede Can you review this PR please? |
|
@robjtede ping |
robjtede
approved these changes
Feb 1, 2024
wthrk
pushed a commit
to wthrk/actix
that referenced
this pull request
Mar 13, 2024
* Expose `ContextFut::restart` * Corrections * `CHANGES.md` corrections * Docs corrections --------- Co-authored-by: 50U10FCA7 <m.bashilov.srg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Check your PR fulfills the following:
Overview
Motivation
Making possible to implement custom
actix::Supervisortypes.Problem
actix::Supervisordoes not allow to shutdown anactix::Actorit supervising. In this case a customactix::Supervisorshould be implemented by the user to satisfy it needs (graceful shutdown of a supervisedactix::ActorviaSupervisor::shutdownin my case for example). But there is no way to implement a customactix::Supervisortype becauseactix::ContextFut::restartis crate-local and can't be used in usercode.Solution
Make
actix::ContextFut::restartpublic.