Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added path type as a possible value for rtype result #575

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Added path type as a possible value for rtype result #575

merged 4 commits into from
Feb 1, 2024

Conversation

delef
Copy link
Contributor

@delef delef commented Jan 29, 2024 •
edited

Added the ability to work with a value without a string literal, to work better with language servers.

#[derive(Message)]
#[rtype(result = Subtracted)]
struct Difference(usize, usize);

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

@delef
Copy link
Contributor Author

delef commented Jan 29, 2024 •
edited

@robjtede a minor but handy feature =)

@delef delef changed the title Added path type as a possible value for rtype Added path type as a possible value for rtype result Jan 29, 2024
robjtede
robjtede approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice QoL change, thanks 👍🏻

@robjtede robjtede added this pull request to the merge queue Feb 1, 2024
@robjtede robjtede added the A-actix Crate: actix label Feb 1, 2024
Merged via the queue into actix:master with commit 25242ab Feb 1, 2024
9 checks passed
wthrk pushed a commit to wthrk/actix that referenced this pull request Mar 13, 2024
@delef @robjtede @wthrk
Added path type as a possible value for rtype result (actix#575)
c4bd58d 
* Added path as a possible value for rtype

* chore: remove bare rtype fail test

* chore: fix trybuild

---------

Co-authored-by: Rob Ede <robjtede@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-actix Crate: actix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delef @robjtede