Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging when the API fails to download a file #1396

Merged
merged 2 commits into from Jul 24, 2023

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Jul 24, 2023

See #1394.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 24, 2023
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit ce0bbd6
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64bed23d1846320008438aaa
😎 Deploy Preview https://deploy-preview-1396.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB -> 2.08 MB (+14 B) +0.00%
Changeset
File Δ Size
../loot-core/src/shared/errors.ts 📈 +27 B (+0.93%) 2.83 KB -> 2.85 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 858.3 KB -> 858.31 KB (+14 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/wide-components.chunk.js 156.7 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/reports.chunk.js 32.35 KB 0%
static/js/narrow-components.chunk.js 32.15 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB -> 1.97 MB (+56 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/shared/errors.ts 📈 +29 B (+0.89%) 3.18 KB -> 3.21 KB
packages/loot-core/src/server/api.ts 📈 +55 B (+0.35%) 15.46 KB -> 15.51 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1009.32 KB -> 1009.38 KB (+56 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 24, 2023
@j-f1 j-f1 merged commit 9c527e3 into master Jul 24, 2023
16 checks passed
@j-f1 j-f1 deleted the jed/better-download-error branch July 24, 2023 19:48
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Jul 24, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants