docs: remove redundant general setting image #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Rationale Since the steps above the image already highlight how to view/modify the default token permission having this image would be redundant.
|
HI @ad-m can you take a look when you get a chance? Thanks |
ZPascal
requested changes
Mar 16, 2024
| @@ -27,13 +27,12 @@ Make sure to save your changes before exiting the settings page. | |||
| > [!NOTE] | |||
| > | |||
| > Granting `Read and write permissions` allows workflows to modify your repository, which can include adding or updating files and code. Always ensure that you trust the workflows you enable with these permissions. | |||
|
|
|||
|
|
|||
|  | |||
There was a problem hiding this comment.
We can take out the picture, but I would suggest that we describe the location of the settings better.
|
|
||
|  | ||
|
|
||
| The `GITHUB_TOKEN` permissions can also be configured globally for all jobs in a workflow or individually for each job. This example demonstrates how to set the necessary permissions for the `contents` and `pull-requests` scopes on a job level: | ||
| The `GITHUB_TOKEN` permissions can also be configured globally for all jobs in a workflow or individually for each job. | ||
|
|
There was a problem hiding this comment.
Why are you putting a paragraph in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Since the steps above the image already highlight how to view/modify the default token permission having this image would be redundant.