fix(csv-stringify): node 12 compatibility in flush

adaltas · Nov 19, 2021 · 9145b75 · 9145b75
1 parent 30f7c84
commit 9145b75
Show file tree

Hide file tree

Showing 17 changed files with 85 additions and 0 deletions.
diff --git a/packages/csv-stringify/dist/cjs/index.cjs b/packages/csv-stringify/dist/cjs/index.cjs
@@ -295,6 +295,11 @@ class Stringifier extends stream.Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv-stringify/dist/cjs/sync.cjs b/packages/csv-stringify/dist/cjs/sync.cjs
@@ -295,6 +295,11 @@ class Stringifier extends stream.Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv-stringify/dist/esm/index.js b/packages/csv-stringify/dist/esm/index.js
@@ -5257,6 +5257,11 @@ class Stringifier extends Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv-stringify/dist/esm/sync.js b/packages/csv-stringify/dist/esm/sync.js
@@ -5257,6 +5257,11 @@ class Stringifier extends Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv-stringify/dist/iife/index.js b/packages/csv-stringify/dist/iife/index.js
@@ -5260,6 +5260,11 @@ var csv_stringify = (function (exports) {
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv-stringify/dist/iife/sync.js b/packages/csv-stringify/dist/iife/sync.js
@@ -5260,6 +5260,11 @@ var csv_stringify_sync = (function (exports) {
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv-stringify/dist/umd/index.js b/packages/csv-stringify/dist/umd/index.js
@@ -5263,6 +5263,11 @@
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv-stringify/dist/umd/sync.js b/packages/csv-stringify/dist/umd/sync.js
@@ -5263,6 +5263,11 @@
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv-stringify/lib/index.js b/packages/csv-stringify/lib/index.js
@@ -314,6 +314,11 @@ class Stringifier extends Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv/dist/cjs/index.cjs b/packages/csv/dist/cjs/index.cjs
@@ -1987,6 +1987,11 @@ class Stringifier extends stream.Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv/dist/cjs/sync.cjs b/packages/csv/dist/cjs/sync.cjs
@@ -1809,6 +1809,11 @@ class Stringifier extends stream.Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv/dist/esm/index.js b/packages/csv/dist/esm/index.js
@@ -7013,6 +7013,11 @@ class Stringifier extends Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv/dist/esm/sync.js b/packages/csv/dist/esm/sync.js
@@ -6835,6 +6835,11 @@ class Stringifier extends Transform {
     callback(err);
   }
   _flush(callback){
+    if(this.state.stop === true){
+      // Note, Node.js 12 call flush even after an error, we must prevent
+      // `callback` from being called in flush without any error.
+      return;
+    }
     if(this.info.records === 0){
       this.bom();
       const err = this.headers();

diff --git a/packages/csv/dist/iife/index.js b/packages/csv/dist/iife/index.js
@@ -7016,6 +7016,11 @@ var csv = (function (exports) {
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv/dist/iife/sync.js b/packages/csv/dist/iife/sync.js
@@ -6838,6 +6838,11 @@ var csv_sync = (function (exports) {
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv/dist/umd/index.js b/packages/csv/dist/umd/index.js
@@ -7019,6 +7019,11 @@
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();

diff --git a/packages/csv/dist/umd/sync.js b/packages/csv/dist/umd/sync.js
@@ -6841,6 +6841,11 @@
                 callback(err);
               }
               _flush(callback){
+                if(this.state.stop === true){
+                  // Note, Node.js 12 call flush even after an error, we must prevent
+                  // `callback` from being called in flush without any error.
+                  return;
+                }
                 if(this.info.records === 0){
                   this.bom();
                   const err = this.headers();