An empty working directory argument or option (deprecated) is ignored in minver-cli #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamralph
added
bug
adamralph
force-pushed
the
empty-working-directory
branch
from
fc72f12
to
2275f61
Compare
adamralph
force-pushed
the
empty-working-directory
branch
from
2275f61
to
a91a3ef
Compare
|
released in 3.0.0-alpha.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s)
1.0.0 - 2.5.0
To reproduce
Steps to reproduce the behaviour:
minver-cli ""in a Windows command prompt (not PowerShell).Expected behaviour
The command fails with
Actual behaviour
The command succeeds.
Workarounds
Avoid passing an empty working directory argument.
Additional context
Fixing this is regarded as a breaking change, since current consumers may rely on the incorrect behaviour.
The behaviour is not reproducible in PowerShell because PowerShell appears to ignore
""and does not propagate it as an argument.