pass rowIdx to renderEditCell #3511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rowIdx` is passed to `renderCell` but not to `renderEditCell`. This PR fixes that unless there's any reason otherwise.
In my use case, I'm rendering a custom `input` component that updates a react-hook-form context, and it references the form field using the dot notation e.g. `persons.1.height` etc.
The status quo with rdg only exposing `row`, I have to expand my rows objects to contain their own indexes, or do a `rows.findIndex`, which forces me to declare `columns` inside the render cycle and deal with memoization etc. Neither are ideal, especially because the solution is right under our noses.
The proposed PR makes it trivially simple to achieve that:
```ts
renderEditCell: ({ rowIdx, column }) => {
return <input name={`myField.${rowIdx}.${column.key}`} />;
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rowIdxis passed torenderCellbut not torenderEditCell. This PR fixes that unless there's any reason otherwise.In my use case, I'm rendering a custom
inputcomponent that updates a react-hook-form context, and it references the form field using the dot notation e.g.persons.1.heightetc.The status quo with rdg only exposing
row, I have to expand my rows objects to contain their own indexes, or do arows.findIndex, which forces me to declarecolumnsinside the render cycle and deal with memoization etc. Neither are ideal, especially because the solution is right under our noses.The proposed PR makes it trivially simple to achieve that: