Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fallback to autogen.sh if configure fails, and refactor config and build scripts for easier troubleshooting #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Jan 11, 2022

  1. fix: Build for darwin-arm64 (Apple M1)

    - `liblzma-config.sh`: If configure fails, run autogen.sh / autoconf (*)
    - refactor `build` action in `bindings.gyp` so that config and build scripts output is shown, making troubleshooting easier
      - `build` action refactored into `build` and `configure` actions with dependencies between them
      - since `configure` is a separate action instead of a command that runs as part of the 'input' key, it is free to output anything
      - script output is made less verbose and more clear, so it's not necessary to send to log file
      - this essentially means that configure & build could be the same script (configure is not run as part of configure stage of gyp)
    - for reference, add link to XZ library used to README.md
    
    (*) The drawback of this is that the fallback to autoconf requires a full autoconf type build environment, but it is a last resort fallback.
    beorn committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    8e7cfb9 View commit details
    Browse the repository at this point in the history