Eslint: re-enable 'jest/valid-title' rule

See: jest-community/eslint-plugin-jest#470 (comment) adeira-source-id: 594a91ef3798662ca61379abbba0ef7b6d04117b
adeira · Oct 27, 2020 · c0b88fc · c0b88fc
1 parent 590afb8
commit c0b88fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/__tests__/__snapshots__/index.test.js.snap b/__tests__/__snapshots__/index.test.js.snap
@@ -297,7 +297,7 @@ Object {
     "jest/valid-describe": 2,
     "jest/valid-expect": 2,
     "jest/valid-expect-in-promise": 2,
-    "jest/valid-title": 0,
+    "jest/valid-title": 1,
     "jsx-a11y/accessible-emoji": 2,
     "jsx-a11y/alt-text": 2,
     "jsx-a11y/anchor-has-content": 0,
@@ -913,6 +913,11 @@ Snapshot Diff:
 -     "jest/prefer-hooks-on-top": 1,
 +     "jest/prefer-hooks-on-top": 2,
       "jest/prefer-inline-snapshots": 0,
+@@ --- --- @@
+      "jest/valid-expect-in-promise": 2,
+-     "jest/valid-title": 1,
++     "jest/valid-title": 2,
+      "jsx-a11y/accessible-emoji": 2,
 @@ --- --- @@
       "no-implied-eval": 2,
 -     "no-import-assign": 1,

diff --git a/ourRules.js b/ourRules.js
@@ -319,7 +319,7 @@ module.exports = {
   'jest/valid-describe': ERROR,
   'jest/valid-expect': ERROR,
   'jest/valid-expect-in-promise': ERROR,
-  'jest/valid-title': OFF, // See: https://github.com/jest-community/eslint-plugin-jest/issues/470
+  'jest/valid-title': NEXT_VERSION_ERROR,
 
   // prefer-object-spread (https://github.com/bryanrsmith/eslint-plugin-prefer-object-spread)
   'prefer-object-spread/prefer-object-spread': WARN,