Skip to content

Commit

Permalink
Eslint config: upgrade eslint-plugin-react to version 7.26.0
Browse files Browse the repository at this point in the history
This change updates `eslint-plugin-react` to the latest version 7.26.0
and workarounds `fbt` oddities discovered in the previous version (jsx-eslint/eslint-plugin-react#3080).
I added 2 fixtures to make sure `no-unused-vars` rule works as expected
with FBT.

Additionally, it removes unused suppression comments that were also fixed
in previous React plugin version (jsx-eslint/eslint-plugin-react#3063).

Changelog: https://github.com/yannickcr/eslint-plugin-react/blob/eeb0144f14aa972f533e2ef0b094f6742d63c492/CHANGELOG.md#7260---20210920

adeira-source-id: 97d82ba734142c6ba2e1c37e3ab006477659b77c
  • Loading branch information
mrtnzlml authored and adeira-github-bot committed Sep 23, 2021
1 parent ec6ea09 commit cd1a02c
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/ShipitConfig.js
Expand Up @@ -67,14 +67,8 @@ export default class ShipitConfig {
getDefaultShipitFilter(): ChangesetFilter {
return (changeset: Changeset) => {
const ch1 = addTrackingData(changeset);
// React Eslint plugin bug: https://github.com/yannickcr/eslint-plugin-react/issues/3063
// eslint-disable-next-line react/no-this-in-sfc
const ch2 = stripExceptDirectories(ch1, this.getSourceRoots());
// React Eslint plugin bug: https://github.com/yannickcr/eslint-plugin-react/issues/3063
// eslint-disable-next-line react/no-this-in-sfc
const ch3 = moveDirectories(ch2, this.directoryMapping);
// React Eslint plugin bug: https://github.com/yannickcr/eslint-plugin-react/issues/3063
// eslint-disable-next-line react/no-this-in-sfc
const ch4 = stripPaths(ch3, this.strippedFiles);

// First we comment out lines marked with `@x-shipit-disable`.
Expand Down

0 comments on commit cd1a02c

Please sign in to comment.