Eslint config: upgrade eslint-plugin-react to version 7.26.0
#3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtnzlml
force-pushed
the
eslint_config_react_plugin_7.26.0
branch
from
ac56822
to
ec6f58e
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
michalsanger
approved these changes
Sep 23, 2021
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
eslint_config_react_plugin_7.26.0
branch
from
dc1b785
to
49ae177
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
This change updates `eslint-plugin-react` to the latest version 7.26.0 and workarounds `fbt` oddities discovered in the previous version (jsx-eslint/eslint-plugin-react#3080). I added 2 fixtures to make sure `no-unused-vars` rule works as expected with FBT. Additionally, it removes unused suppression comments that were also fixed in previous React plugin version (jsx-eslint/eslint-plugin-react#3063). Changelog: https://github.com/yannickcr/eslint-plugin-react/blob/eeb0144f14aa972f533e2ef0b094f6742d63c492/CHANGELOG.md#7260---20210920
mrtnzlml
force-pushed
the
eslint_config_react_plugin_7.26.0
branch
from
49ae177
to
596d202
Compare
vercel
bot
temporarily deployed
to
Preview – universe-example-relay
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
eslint-plugin-reactto the latest version 7.26.0and workarounds
fbtoddities discovered in the previous version (jsx-eslint/eslint-plugin-react#3080).I added 2 fixtures to make sure
no-unused-varsrule works as expectedwith FBT.
Additionally, it removes unused suppression comments that were also fixed
in previous React plugin version (jsx-eslint/eslint-plugin-react#3063).
Changelog: https://github.com/yannickcr/eslint-plugin-react/blob/eeb0144f14aa972f533e2ef0b094f6742d63c492/CHANGELOG.md#7260---20210920