Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint: upgrade to version 8.0.0 #3274

Merged
merged 1 commit into from Dec 30, 2021
Merged

Eslint: upgrade to version 8.0.0 #3274

merged 1 commit into from Dec 30, 2021

Conversation

mrtnzlml
Copy link
Member

@mrtnzlml mrtnzlml commented Oct 11, 2021

See:

Known unresolved issues (with low impact )that we decided to accept:

Known issues that need to be fixed first:

@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 11, 2021 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 11, 2021 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 14, 2021 13:05 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 14, 2021 13:05 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 17, 2021 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 17, 2021 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 19, 2021 13:42 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 19, 2021 13:42 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 26, 2021 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 26, 2021 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 26, 2021 14:01 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 26, 2021 14:01 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website October 26, 2021 14:14 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay October 26, 2021 14:14 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay November 13, 2021 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website November 13, 2021 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay November 13, 2021 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website November 13, 2021 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay November 23, 2021 22:51 Inactive
@mrtnzlml mrtnzlml marked this pull request as ready for review December 24, 2021 19:55
@mrtnzlml mrtnzlml added this to In progress in adeira/universe (general) via automation Dec 24, 2021
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 24, 2021 20:10 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 24, 2021 20:10 Inactive
@mrtnzlml
Copy link
Member Author

mrtnzlml commented Dec 29, 2021

Hola @Brianzchen 👋 Would you happen to know why are the tests failing because of eslint-plugin-ft-flow on Eslint 8? 🤔 Is eslint-plugin-ft-flow tested against Eslint 8? Does it support this latest Eslint version?

@Brianzchen
Copy link

So I raised an issue about this here. I guess I understand what this dodgy code does now. My projects are on eslint v8 but I suppose it never impacted me because I never used this rules.

This is an easy fix let me raise a PR for you shortly

@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 29, 2021 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 29, 2021 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 29, 2021 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 29, 2021 16:40 Inactive
@maicol07
Copy link

@mrtnzlml I think this can be merged now that all the plugins have been updated!

See:

- https://eslint.org/blog/2021/10/eslint-v8.0.0-released
- https://eslint.org/docs/user-guide/migrating-to-8.0.0

Known unresolved issues (with low impact )that we decided to accept:

- mysticatea/eslint-plugin-node#301

Known issues that need to be fixed first:

- [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here
- [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here
- [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here
- [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8
- [x] wait for facebook/react#22248 to be released and merged here
- [x] release minor/patch version of Adeira Eslint Config before merging this breaking change
- [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website December 30, 2021 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay December 30, 2021 16:40 Inactive
@kodiakhq kodiakhq bot merged commit b194be7 into master Dec 30, 2021
adeira/universe (general) automation moved this from In progress to Done Dec 30, 2021
@kodiakhq kodiakhq bot deleted the eslint_8 branch December 30, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants