Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement role for 14-sles #61

Merged
merged 5 commits into from
May 22, 2024
Merged

Implement role for 14-sles #61

merged 5 commits into from
May 22, 2024

Conversation

pierreoxs
Copy link

No description provided.

Copy link
Collaborator

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the way this project (ab-)uses Ansible task results:
https://github.com/adfinis/ansible-collection-maintenance/blob/main/README.md?plain=1#L10-L16

(Yes, I know it can be a bit counterintuitive...)

roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
@pierreoxs
Copy link
Author

@s3lph A new commit is available for review

@s3lph
Copy link
Collaborator

s3lph commented May 14, 2024

@pierreoxs you can simply use the "Re-request review" button at the top right:
image

roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
@pierreoxs pierreoxs requested a review from s3lph May 17, 2024 13:35
@pierreoxs
Copy link
Author

Hey @s3lph , new commit available and I used the "Re-request review" button :)

Copy link
Collaborator

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only these two minor things, then I think this can be merged.

roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
roles/maintenance_14_sles/tasks/main.yml Outdated Show resolved Hide resolved
@pierreoxs pierreoxs requested a review from s3lph May 21, 2024 15:08
@s3lph s3lph merged commit be298f4 into main May 22, 2024
2 checks passed
@s3lph s3lph deleted the 14-sles branch May 22, 2024 08:25
@s3lph
Copy link
Collaborator

s3lph commented May 22, 2024

Released as 0.1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants