-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement role for 14-sles #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the way this project (ab-)uses Ansible task results:
https://github.com/adfinis/ansible-collection-maintenance/blob/main/README.md?plain=1#L10-L16
(Yes, I know it can be a bit counterintuitive...)
@s3lph A new commit is available for review |
@pierreoxs you can simply use the "Re-request review" button at the top right: |
Hey @s3lph , new commit available and I used the "Re-request review" button :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only these two minor things, then I think this can be merged.
Released as 0.1.24. |
No description provided.