chore(ci/api): use pytest-github-actions-annotate-failures #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0rydoras
added
backend
hairmare
reviewed
Mar 8, 2024
.github/workflows/backend.yaml
Outdated
| @@ -31,5 +31,7 @@ jobs: | |||
| run: docker compose up -d --build db api | |||
| - name: Check for missing migrations | |||
| run: docker compose exec -T api ./manage.py makemigrations --check --dry-run --no-input | |||
| - name: Install pytest-github-actions-annotate-failures | |||
| run: docker compose run --rm -T api pip install pytest-github-actions-annotate-failures | |||
There was a problem hiding this comment.
i'm not 💯 convinced this will work, maybe you also need to ensure that the GITHUB_TOKEN env var gets passed into the container where the actual tests are run.
There was a problem hiding this comment.
You are probably right, it didn't annotate any of the ~50 warnings
hairmare
previously approved these changes
Mar 8, 2024
c0rydoras
force-pushed
the
chore/tests/pytest-github-actions-annotate-failures
branch
11 times, most recently
from
4846aba
to
d2cabbd
Compare
hairmare
reviewed
Mar 11, 2024
.github/workflows/backend.yaml
Outdated
| - name: Run backend tests | ||
| run: make api-test | ||
| - name: Run tests | ||
| run: docker-compose run --rm -T api sh -c 'pip install pytest-github-actions-annotate-failures && GITHUB_ACTIONS=true ENV=test PYTEST_RUN_PATH=/app pytest --no-cov-on-fail --cov -vvv -s' |
There was a problem hiding this comment.
why not use the --env / -e flags to pass envs?
There was a problem hiding this comment.
i did that, sadly it doesn't look like the screenshot
c0rydoras
force-pushed
the
chore/tests/pytest-github-actions-annotate-failures
branch
from
d2cabbd
to
4e59f29
Compare
c0rydoras
force-pushed
the
chore/tests/pytest-github-actions-annotate-failures
branch
from
4e59f29
to
238a6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.