Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1224 Deprecated code warning in hugo v0.112.0 #1225

Closed

Conversation

darrenkearney
Copy link

@darrenkearney darrenkearney commented May 23, 2023

Changed site variables from 'Language.Params' -> 'Site.Params'.
Note this change may conflict with hugo versions less than v0.112.0

See hugo docs:
https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120

See hugo-PaperMod Issue:
#1224

modified:   _default/single.html
modified:   partials/header.html

What does this PR change? What problem does it solve?
Issue described here: #1224

Was the change discussed in an issue or in the Discussions before?
No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • [?] This change updates the overridden internal templates from HUGO's repository.

I'm not 100% certain about the last item in the PR checklist. Please let me know if this is an issue.

Changed site variables from 'Language.Params' -> 'Site.Params'
Note this change may conflict with hugo versions less than v0.112.0

See hugo docs:
  https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120

See hugo-PaperMod Issue:
  adityatelange#1224

	modified:   _default/single.html
	modified:   partials/header.html
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SirUli
Copy link

SirUli commented May 28, 2023

Looks like bep had second thoughts on this: gohugoio/hugo#11025

No longer a warning after 0.112.4

@darrenkearney
Copy link
Author

Looks like bep had second thoughts on this: gohugoio/hugo#11025

No longer a warning after 0.112.4

Thanks! Closing this pull request.

@darrenkearney darrenkearney deleted the pull-request-1224 branch August 9, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants