refactor: use window.location as base for url construction #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
kptdobe
approved these changes
Dec 18, 2023
arumsey
reviewed
Jan 16, 2024
| @@ -10,7 +10,7 @@ export default async function decorate(block) { | |||
| block.textContent = ''; | |||
|
|
|||
| // load footer fragment | |||
| const footerPath = footerMeta.footer || '/footer'; | |||
| const footerPath = footerMeta ? new URL(footerMeta, window.location).pathname : '/footer'; | |||
There was a problem hiding this comment.
This also fixes the bug (#264) with footerMeta now being a string and not an object so footerMeta.footer can never be valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces instances of creating URL objects with a single argument with the two-argument form, using
window.locationas the base URL. Ensures that relative URLs are resolved against the current browser location for consistent handling.Test URLs: