fix: cards fail if the text contains an icon #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since icons
:icon-name:
are rendered as<span class="icon icon-icon-name"></span>
and decorated with<span class="icon icon-icon-name"><img ...></span>
now, querying all<img>
in the list of cards and assuming they all have a closest<picture>
is wrong. It will fail for the icon<img>
and the cards block will be broken.With this change I limit the selector to
<img>
that actually have a<picture>
parent.Test URLs: