HTML container component #1178
Open
HTML container component #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
This pull request introduces 10 alerts when merging 0a99146 into 19c0a14 - view on LGTM.com new alerts:
|
vladbailescu
added
the
move-to-contrib
10 tasks
vladbailescu
added a commit
to adobe/aem-contrib-wcm-components
that referenced
this pull request
Nov 9, 2021
HTML container component * based on adobe/aem-core-wcm-components#1178 Co-authored-by: bschuhma <bschuhma@adobe.com> Co-authored-by: Vishal Singh Arya <varya@adobe.com> Co-authored-by: Abhinav Saraswat <abhinavsaraswat@Abhinavs-MacBook-Pro.local> Co-authored-by: Vlad <vlad@bailescu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML component addresses customers' needs/desires to write their own HTML, while implementing some element of formality by forcing them to use only files in the DAM. Instead of customers just free-handing code that hasn't undergone any form of peer review, hopefully this component will force them to review the HTML/CSS/JS and put it into the DAM.
The component allows for multiple CSS and JS files to support the one HTML file. The CSS files can be brought in inline or via reference, while the JS files can be brought in via async, defer, reference and inline.