-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Page] Extend meta attributes #663 #744
base: main
Are you sure you want to change the base?
Conversation
dymitrs
commented
Sep 18, 2019
•
edited
edited
Q | A |
---|---|
Fixed Issues? | Fixes #663 |
Patch: Bug Fix? | Some Sonarlint fixes like deleted redundant throws. |
Minor: New Feature? | Yes - OG, Facebook, Twitter meta tags extended, Canonical URL |
Major: Breaking Change? | No |
Tests Added + Pass? | Yes |
Documentation Provided | Yes (code comments and or markdown) |
Any Dependency Changes? | Yes, added Apache dependency to Core pom.xml |
License | Apache License, Version 2.0 |
- Extended meta tags attributes - they are configurable on Page policy and can be enabled by checkbox in Properties of page (Social Media tab). Configuration can be extended on Page level. (after enabling a checkbox, textfield could appear where page id, account id or twitter username can be set. If setup this way, configuration from Page properties will be taken as first instead of the page policy conf).
- Added Canonical URL feature for pages that use Page component (for rendition).
Codecov Report
@@ Coverage Diff @@
## development #744 +/- ##
=================================================
+ Coverage 82.81% 82.85% +0.04%
- Complexity 1096 1111 +15
=================================================
Files 110 111 +1
Lines 3450 3488 +38
Branches 634 640 +6
=================================================
+ Hits 2857 2890 +33
- Misses 224 226 +2
- Partials 369 372 +3
Continue to review full report at Codecov.
|
@bpauli @richardhand |
@gabrielwalt could you check if this implementation fulfills your requirements from #663 |
Hi @zajcu, we're currently busy with working on a Data Layer and will likely not be able to make this contribution progress before end of October. I'm really sorry that we lack the capacity to handle such valuable pull requests in a more timely manner. It is however among the top issues in our backlog, so that we can pick it up as soon as we'll have some slack again. |
…eResolver map to support rewritted URL's.
Hi @gabrielwalt, what's the plan regarding this feature now that the data layer has been officially released? A client is requesting this feature and it would be great not to write it as a completely custom piece. |