Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use user-defined dist folder for last-built-actions.json #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hparra
Copy link
Contributor

@hparra hparra commented Mar 12, 2024

Description

Fix hardcoded "dist" folder for 'last-built-actions.json'.

Related Issue

I suspect there are a few more of these, e.g. SSL certs, log forwarding SHA, etc.

Motivation and Context

app.manifest.yaml allows for custom dist folder but not all part of tool respect it.

How Has This Been Tested?

  • unit tests
  • hot patch + blackbox test: DEBUG=@adobe/aio-lib-runtime* npm run build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9bff007) to head (e95d749).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1303      1303           
  Branches       346       346           
=========================================
  Hits          1303      1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hparra hparra changed the title Fix hardcoded dist folder for last-built-actions.json fix: use user-defined dist folder for last-built-actions.json Mar 12, 2024
@hparra
Copy link
Contributor Author

hparra commented Mar 12, 2024

Highly suspect. "Works" but the last-built-actions.json is now nowhere to be seen, even though DEBUG statements and additional hotpatched logs show that it is successfully read.

@hparra hparra closed this Mar 12, 2024
@hparra hparra reopened this Mar 12, 2024
@hparra hparra marked this pull request as ready for review March 12, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant