Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for IE 11 #1047

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Remove support for IE 11 #1047

wants to merge 21 commits into from

Conversation

carterworks
Copy link
Contributor

@carterworks carterworks commented Oct 5, 2023

Important

This PR must not be merged before gaining approval of all the stakeholders. They need to be aware that they will not be collecting data from IE and need to be okay with that. The question: "How much money does Adobe lose (or how many hits are left on the table) by dropping support for IE11?" needs to be answered.

Description

  • Remove IE 11 and 10 from the Babel transpiration targets
  • Remove and re-write the utilities that worked around IE limitations

Related Issue

PDCL-11084

Motivation and Context

Removing support for IE will decrease the library size and allow us to use more convenient syntax and features, like Array.prototype.includes, async/await, and array and object destructuring.

$ npm run clean && npm run build && gzip --keep dist/alloy.min.js && du -ah dist/

With IE10 and 11 target
 32K    dist/alloy.min.js.gz
 92K    dist/alloy.min.js
444K    dist/alloy.js
568K    dist

Without IE10 and 11 target
 28K    dist/alloy.min.js.gz
 84K    dist/alloy.min.js
428K    dist/alloy.js
540K    dist

…and without `utils/assign.js`, `utils/find.js`, `utils/includes.js` `utils/values.js`, rewriting `utils/querystring.js`, `utils/isNumber.js`, `utils/isUnique.js`, `utils/padStart.js`, and removing `@adobe/reactor-query-string`, `@adobe/reactor-object-assign`, and `css.escape`
 28K    dist/alloy.min.js.gz
 80K    dist/alloy.min.js
420K    dist/alloy.js
528K    dist

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks changed the title Pdcl 11804 remove ie 11 Remove support for IE 11 Oct 5, 2023
rollup.config.js Outdated Show resolved Hide resolved
src/utils/isNumber.js Show resolved Hide resolved
src/utils/querystring.js Show resolved Hide resolved
@jfkhoury jfkhoury added the ignore-for-release Do not include this PR in release notes label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants