Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automated testing #1093

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Fix automated testing #1093

merged 8 commits into from
Jan 8, 2024

Conversation

jonsnyder
Copy link
Contributor

@jonsnyder jonsnyder commented Jan 2, 2024

Description

Fix automated testing. Fixing the Firefox issue required updating a transitive dependency (karma-runner/karma-sauce-launcher#275) A bunch of the AJO tests and a couple of mixed-mode tests are failing. Some locally and some only through sauce labs. They appear to be issues with the activities that are returned. I've skipped these tests and made JIRA tickets for fixing them.

Related Issue

Fix AJO tests: https://jira.corp.adobe.com/browse/PDCL-11484
Fix mixed-mode tests: https://jira.corp.adobe.com/browse/PDCL-11485

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@shammowla
Copy link
Collaborator

@jonsnyder should I create tickets for the skipped tests?

@jonsnyder
Copy link
Contributor Author

@jonsnyder should I create tickets for the skipped tests?

I just did.

@jonsnyder jonsnyder merged commit af2ed62 into main Jan 8, 2024
4 of 14 checks passed
@jonsnyder jonsnyder deleted the fixTests branch January 8, 2024 21:49
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants