Sandbox updates #1099
Open
Sandbox updates #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this includes all the changes from #1087. Not sure if that was intentional or not |
shammowla
force-pushed
the
sandbox-updates
branch
from
d23a4c7
to
683493d
Compare
shammowla
force-pushed
the
sandbox-updates
branch
from
683493d
to
5d9a91c
Compare
shammowla
force-pushed
the
sandbox-updates
branch
from
a2372ac
to
9bdf4b7
Compare
shammowla
requested review from
carterworks,
jonsnyder,
jfkhoury and
ninaceban
|
While testing the custom build script, our current sandbox was running on deprecated npm packages that required updates. Deployed it to alloyio.com to test. Once approved, I'll rebase the changes to custom build branch. |
|
@carterworks can you please review the PR? @ninaceban do you see any breaking changes to target? |
carterworks
approved these changes
Jan 18, 2024
jfkhoury
reviewed
Jan 18, 2024
sandbox/public/index.css
Outdated
| color: #acecfe; | ||
| } | ||
| monospace; | ||
| color: #acecfe; |
There was a problem hiding this comment.
Let's make the color darker to be more readable on a white background.
jfkhoury
reviewed
Jan 18, 2024
| color: #eaeaea; | ||
| } | ||
|
|
||
| a { | ||
| color: #e7ca8d; | ||
| nav { |
There was a problem hiding this comment.
Can we please make the left nav a little wider?
jfkhoury
approved these changes
Jan 18, 2024
|
@jfkhoury Refactored tags to use the corresponding React Spectrum components. Fixed the coloring and added support for responsiveness. |
shammowla
force-pushed
the
sandbox-updates
branch
from
d7b17ef
to
a321aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: