-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies. #1114
Merged
Merged
Update dependencies. #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing UACH functional tests * Updated some husky pre-commit scripts
dompuiu
force-pushed
the
update_dependencies
branch
from
May 16, 2024 22:30
ca3fa23
to
9b54e19
Compare
jonsnyder
approved these changes
May 17, 2024
Thank you so much, @dompuiu, for taking on this effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dependencies on this project were not updated in a long time.
Related Issue
Motivation and Context
The dependencies were very old. A lot of dependencies moved to ES modules. TestCafe changed a lot. This project was using a 2 major versions old Prettier. ESLint released a new config format file. So a lot of reasons.
Big changes moving forward:
One know issue is that I cannot make the scripttest:functional:watch
work. Needs more investigation on how to make that work.test:functional:watch
seems to have issue when the--esm
flag is used. Since we no longer use it, now the watch command works.Update: It seems that Chrome and Edge are controlled using native automation protocol, while Firefox or Safari are controlled using a reverse proxy (the method that was used to control all the browsers in TestCafe 2.6). Because of that, I was forced to undo or tweak some of the fixes I made initially for Chrome. Examples of differences:
.alloyio.com
. In Safari and Firefox it needs to be set onalloyio.com
, otherwise the TestCafe reverse proxy ignores it. So the solution I choose is to set one cookie for each domain.I was forced to add a few tests to the ignore list: C8631576 and C8631577. I talked with Don and he said he will take a look. If he find a way to fix those tests, I will remove them from the ignore list.
Screenshots (if appropriate):
Types of changes
Checklist: