Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded testcafe and browserstack provider. #696

Merged
merged 1 commit into from Mar 18, 2021
Merged

Conversation

Aaronius
Copy link
Contributor

Description

Upgraded testcafe and browserstack provider. The latest version of TestCafe has a bug regarding dynamically added CSPs, so I needed to create a separate testing page with the CSP built into the HTML to work around the issue.

Related Issue

https://jira.corp.adobe.com/browse/PDCL-4657
https://jira.corp.adobe.com/browse/PDCL-4602

Motivation and Context

We're running into stability issues when running TestCafe tests. I want to make sure we're on the latest release so we have as many of the available fixes before we dig in further and potentially report more issues on TestCafe and the associated BrowserStack provider.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

Copy link
Contributor

@jfkhoury jfkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@shammowla shammowla self-requested a review March 18, 2021 18:21
@Aaronius Aaronius merged commit cfbcaf8 into main Mar 18, 2021
@Aaronius Aaronius deleted the upgrade-testcafe branch March 18, 2021 18:32
@Aaronius
Copy link
Contributor Author

Related TestCafe issues:
DevExpress/testcafe#6057
DevExpress/testcafe#5612

@github-actions github-actions bot mentioned this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants