Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use md2html instead of reverse-engineering the DOM #189

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Nov 24, 2022

The current implementation of the view doc source feature uses the HTML rendition of the page and revere-engineers the source document. This was initially not a good idea because it cannot be fully precise, for example accurately computing the metadata is impossible (metadata.xslx rules vs computed metadata vs metadata block).

Using the md rendition and show it as html is the point of this PR.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #189 (3aa200c) into main (f5e02aa) will decrease coverage by 11.60%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 3aa200c differs from pull request most recent head 1ad0944. Consider uploading reports for the commit 1ad0944 to get more accurate results

@@             Coverage Diff             @@
##             main     #189       +/-   ##
===========================================
- Coverage   89.94%   78.34%   -11.60%     
===========================================
  Files           5        8        +3     
  Lines        5150     4304      -846     
===========================================
- Hits         4632     3372     -1260     
- Misses        518      932      +414     
Files Coverage Δ
src/extension/view-doc-source/js/blocks.js 95.58% <ø> (-4.42%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant