Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import feature (experimental) #583

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: import feature (experimental) #583

wants to merge 9 commits into from

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Nov 2, 2023

Do not merge until validated with 5 customers (dev users)

This adds a default import capability: on non-helix site, run a predefined import with basic capabilities (see adobe/helix-importer#261) and visualise the result in a popup window. Result is very similar to the View Document Source feature but... for a non-helix website!

To test:

  • open any non-helix site
  • click on the Sidekick button
  • hit the View imported document button 

This depends on:

Before merging, the PR still needs some minor adjustments:

  • finalise the button / feature name
  • translations ?
  • remove the Experimental Sidekick name!

A version of the Sidekick with the feature enabled can be downloaded here: https://adobe-my.sharepoint.com/:u:/r/personal/acapt_adobe_com/Documents/helix/shared/AEM%20Sidekick%20-%20(View%20imported%20document)%20experimental.zip?csf=1&web=1&e=YB32gf
To install it:

  • download the zip
  • unzip it locally
  • go to chrome://extensions/
  • enable Developer Mode (top right corner)
  • Load Unpacked - select the unzipped folder
  • you can have both extensions (the AEM Sidekick and this experimental version) enabled at the same time but I recommend to Disable the official one while you are testing the experiment version to avoid any side effect.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcd9dfa) 89.77% compared to head (ab85603) 89.77%.
Report is 64 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files           6        6           
  Lines        5253     5253           
=======================================
  Hits         4716     4716           
  Misses        537      537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant