stop propagation of clicks on tooltips

[snow893]

Closes #4480

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Open new storybook entry. Click red box. Button toggles disabled state. Try clicking on tooltip, click event is not propagated to the red div.

🧢 Your Project:

[snowystinger]

Great, looks like it's working.

Would you mind adding a test to TooltipTrigger tests as well?

  it('does not propagate pointer or click through the portal', () => {
    let onPointerDown = jest.fn();
    let onPointerUp = jest.fn();
    let onClick = jest.fn();

    let {getByRole} = render(
      <Provider theme={theme}>
        {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events,jsx-a11y/no-static-element-interactions */}
        <div onPointerDown={onPointerDown} onPointerUp={onPointerUp} onClick={onClick}>
          <TooltipTrigger>
            <ActionButton>Trigger</ActionButton>
            <Tooltip>Helpful information.</Tooltip>
          </TooltipTrigger>
        </div>
      </Provider>
    );

    let button = getByRole('button');
    act(() => {
      button.focus();
    });

    let tooltip = getByRole('tooltip');
    triggerPress(tooltip);
    expect(onPointerDown).not.toHaveBeenCalled();
    expect(onPointerUp).not.toHaveBeenCalled();
    expect(onClick).not.toHaveBeenCalled();
  });

[LFDanLu]

A bit concerned about using usePress here just to stop propagation of click events, especially since usePress handles so much extra stuff like preventing text selection. Any reason we don't just use a pointerdown handler with stopPropagation? The tooltip shouldn't be keyboard focusable anyways and tooltips aren't accessible on touch devices so no need for all the extra handling for those right?

[snowystinger]

I think it's fine to stop it with usePress. Because it's more than just pointerDown, we currently still support devices that don't have pointer events, so the full list would be

onPointerDown
onMouseDown
onClick

Might also need it for touch? and maybe the up/move/enter/leave? Seemed easier to let usePress just do it's thing, which is to block anything that might be perceived as a click.