Fix Combobox hidden input default value causing React warnings (name prop) #6336
+3
β3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6327
It just occurred to me that it might also be nice to update the type for
selectedKey
fromKey
toKey | null
.Should I include that as well? Or maybe it's better to address it when converting
packages/@react-stately/list
to TS strict later (I don't see it on thetypescript-strict-plugin
list intsconfig.json
).react-spectrum/packages/@react-stately/list/src/useSingleSelectListState.ts
Lines 25 to 34 in cf0846e
β Pull Request Checklist:
π Test Instructions:
Story
π§’ Your Project: