Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom environment name #118

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

shandilya3
Copy link
Contributor

We have made changes to support custom environment name as in the Target UI under Administration > Environments.
The default environment is set to production.

For CDN, we are always pointing to assets.adobetarget.com, aligning with our Java SDK implementation.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Jun 15, 2023

Coverage Status

coverage: 90.213% (-2.4%) from 92.653%
when pulling 616868e on shandilya3:TNT-47592-environmentFix
into c7aa8ef on adobe:main.

Copy link
Contributor

@dcottingham dcottingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a couple minor comments and then feel free to merge.

packages/target-decisioning-engine/src/utils.js Outdated Show resolved Hide resolved
packages/target-decisioning-engine/src/geoProvider.js Outdated Show resolved Hide resolved
@shandilya3 shandilya3 merged commit 5eb9441 into adobe:main Jun 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants