Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metafiles copying #60

Merged
merged 3 commits into from
Jul 4, 2023
Merged

fix: metafiles copying #60

merged 3 commits into from
Jul 4, 2023

Conversation

Julien-R44
Copy link
Member

As you saw, cpy has had some breaking changes and they've changed their APIs. So if we follow their changelog, then you seem to have made the change the right way.
However, it seems to doesn't work as expected :

For a metaFiles pattern /resources/views/**.*.edge and the given directory structure :

  resources/
    views/
       view.edge
        admin/
            admin.edge

After copying, we will have this result in the ./build folder:

build/
  view.edge
  admin/
    admin.edge

I don't know why, I've tried a lot of different things to make it works but I think that it's a bug on the cpy side. so I suggest we just rollback temporarily. not super important I think

Also added a test that check we keep the original directory structure

@thetutlage
Copy link
Member

Should we try with cpy@10.0?

@thetutlage
Copy link
Member

Tracking it here. sindresorhus/cpy#113

Let's see if we can find a fix for this before downgrading the version

@thetutlage
Copy link
Member

Let's merge it. It seems like a similar issue with cpy was reported last year and it is still pending.

@thetutlage thetutlage merged commit dbda3b7 into next Jul 4, 2023
12 checks passed
@thetutlage thetutlage deleted the fix/metafiles-copy branch July 4, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants