Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Basic auth guard #243

Merged

Conversation

parker-codes
Copy link
Contributor

πŸ”— Linked issue

No linked issue. Reported in Discord and Romain pointed me in the right place for a PR.

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The docs described Basic Auth as one of the options, but the CLI wouldn't accept it.

node ace add @adonisjs/auth --guard=basic_auth
The selected guard "basic_auth" is invalid. Select one from: session, access_tokens

This PR just adds the missing guard to the config list and adds the type in the missing places.

Since many tests are already failing, I couldn't verify that this doesn't break anything.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit c61ccb1 into adonisjs:develop Apr 2, 2024
7 checks passed
@thetutlage
Copy link
Member

Thanks πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants