Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to ESM #4

Merged
merged 14 commits into from
May 2, 2024
Merged

Rewrite to ESM #4

merged 14 commits into from
May 2, 2024

Conversation

Melchyore
Copy link

@Melchyore Melchyore commented Apr 27, 2024

Proposed changes

Fixes #3

Hello, this is a rewrite of the module to ESM so that we can use it with AdonisJS v6.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

The CI is failing on Windows because it seems that there's a problem with Node 22. There's already an issue for that: nodejs/node#52682

@Julien-R44 Julien-R44 changed the base branch from develop to next May 2, 2024 06:54
@Julien-R44
Copy link
Member

Moving target branch to next, will do a pre-release and create a new PR targeting main

@Julien-R44 Julien-R44 merged commit 2846ad1 into adonisjs:next May 2, 2024
5 checks passed
@Julien-R44 Julien-R44 mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to adonisjs 6
2 participants