Rewrite to ESM (#4) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: rewrite to ESM BREAKING CHANGE * chore: ignore pnpm-lock file * chore: add luxon to fix CI * fix: do not remove protocol from file path * ci: try to fix sqlite error * test: use correct sql file path * chore: use correct provider export * fix: use correct types export * fix: use default export for rmb middleware * fix(rmb_middleware): use correct type for next callback * fix: extend HttpContext interface from provider file * chore: import as type * refactor: augment HttpContext in the middleware * chore: update deps
* feat: rewrite to ESM BREAKING CHANGE * chore: ignore pnpm-lock file * chore: add luxon to fix CI * fix: do not remove protocol from file path * ci: try to fix sqlite error * test: use correct sql file path * chore: use correct provider export * fix: use correct types export * fix: use default export for rmb middleware * fix(rmb_middleware): use correct type for next callback * fix: extend HttpContext interface from provider file * chore: import as type * refactor: augment HttpContext in the middleware * chore: update deps * refactor: remove usage of import.meta.resolve API * fix: use containerProvider to resolve dependencies of controllers methods
|
Merged #6 that needs a quick read/review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite to ESM - V6 Support
PR from @Melchyore via #4