Skip to content

Commit

Permalink
Fix build
Browse files Browse the repository at this point in the history
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
  • Loading branch information
bendemboski committed May 21, 2020
1 parent 8ebdf8d commit 2604346
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions node-tests/fixtures/ember-test/test-index-extra.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@ function testIndexExtra() {
const helper = require('../src/helper');
helper();

const { app, BrowserWindow } = require('electron');

app.once('browser-window-created', (event, win) => {
win.webContents.on('did-finish-load', () => {
let extensions = BrowserWindow.getDevToolsExtensions();
if (!Object.prototype.hasOwnProperty.call(extensions, 'devtron') || !Object.prototype.hasOwnProperty.call(extensions, 'Ember Inspector')) {
console.error('devtron and/or ember-inspector not installed', Object.keys(extensions)); // eslint-disable-line no-console
app.exit(-1);
}
});
});
// disabled until there's a fix for https://github.com/electron/electron/issues/23676
// and ideally for https://github.com/electron/electron/issues/23656
//
// const { app, BrowserWindow } = require('electron');
//
// app.once('browser-window-created', (event, win) => {
// win.webContents.on('did-finish-load', () => {
// let extensions = BrowserWindow.getDevToolsExtensions();
// if (!Object.prototype.hasOwnProperty.call(extensions, 'devtron') || !Object.prototype.hasOwnProperty.call(extensions, 'Ember Inspector')) {
// console.error('devtron and/or ember-inspector not installed', Object.keys(extensions)); // eslint-disable-line no-console
// app.exit(-1);
// }
// });
// });
}

testIndexExtra();

0 comments on commit 2604346

Please sign in to comment.